What are the three testing levels defined in the skill?

Level 1 covers Node.js built-ins and fixtures; Level 2 covers local project binaries like compilers or Docker; Level 3 covers external network dependencies and APIs.

What does this skill look for in an ADR review?

The skill checks for a clear testing strategy, proper assignment of testing levels (1-3), adherence to the 'no-mocking' principle, and consistency with parent architectural decisions.

Why is mocking prohibited by this skill?

It enforces the 'Reality Principle,' which posits that tests should verify behavior against real systems or via dependency injection interfaces rather than using brittle global mocks like vi.mock().

Does this skill help with existing code or just documentation?

It primarily focuses on Architectural Decision Records (ADRs) to ensure the design is sound before implementation, but provides code snippets to guide the correct implementation.

TypeScript Architecture Auditor

Name: TypeScript Architecture Auditor
Author: simonheimlicher

bysimonheimlicher

•

Security & Testing

Evaluates Architectural Decision Records (ADRs) against strict testing principles and dependency injection standards to ensure robust system design.

This skill automates the review of TypeScript architectural decisions by auditing ADRs for compliance with high-integrity testing standards. It enforces a 'reality-based' testing philosophy that replaces fragile mocks with dependency injection and categorizes testing environments into three distinct levels: Node.js built-ins, local binaries, and external services. By analyzing the ADR hierarchy and checking for consistency between product and feature decisions, it provides immediate, actionable feedback including code examples for corrected architectures.

Key Features

01Validates ADRs against a structured three-level testing hierarchy

021 GitHub stars

03Generates correct architectural code snippets to resolve identified violations

04Enforces dependency injection patterns while prohibiting traditional mocking

05Provides automated APPROVED or REJECTED status with specific violation details

06Analyzes architectural consistency across product, capability, and feature levels

Use Cases

01Onboarding developers to strict project-specific testing and architectural standards

02Reviewing technical design documents for new features to ensure long-term testability

03Auditing complex system changes for violations of the 'no-mocking' principle

What are Skills?·How to Install

Install with 🐟 Skill.Fish

npx skillfish add simonheimlicher/spx-claude reviewing-typescript-architecture

For use in Claude.ai and ChatGPT

Download Skill